introduce biome instead of prettier and eslint.

This commit is contained in:
2025-09-30 19:14:47 +09:00
parent dd1fd35238
commit c8a2c8087a
28 changed files with 2311 additions and 838 deletions

View File

@@ -13,11 +13,13 @@
"Ligh", "Ligh",
"moize", "moize",
"officedocument", "officedocument",
"OKUMURA",
"openxmlformats", "openxmlformats",
"pizzip", "pizzip",
"rspack", "rspack",
"SUBTABLE", "SUBTABLE",
"wordprocessingml" "wordprocessingml",
"Yoshihiro"
], ],
"ignorePaths": [".env"] "ignorePaths": [".env", "dist", "node_modules", "scripts", "plugin"]
} }

View File

@@ -1,8 +0,0 @@
{
"$schema": "https://json.schemastore.org/prettierrc",
"semi": true,
"tabWidth": 2,
"singleQuote": true,
"printWidth": 120,
"trailingComma": "all"
}

View File

@@ -1,6 +1,6 @@
{ {
"recommendations": [ "recommendations": [
"esbenp.prettier-vscode", "biomejs.biome",
"streetsidesoftware.code-spell-checker", "streetsidesoftware.code-spell-checker",
"dbaeumer.vscode-eslint", "dbaeumer.vscode-eslint",
"jawandarajbir.react-vscode-extension-pack" "jawandarajbir.react-vscode-extension-pack"

29
.vscode/settings.json vendored
View File

@@ -1,39 +1,30 @@
{ {
"editor.formatOnSave": true, "editor.formatOnSave": true,
"editor.codeActionsOnSave": { "editor.codeActionsOnSave": {
"quickfix.biome": "explicit",
"source.organizeImports": "explicit" "source.organizeImports": "explicit"
}, },
"[javascript]": { "[javascript]": {
"editor.defaultFormatter": "esbenp.prettier-vscode" "editor.defaultFormatter": "biomejs.biome"
}, },
"[javascriptreact]": { "[javascriptreact]": {
"editor.defaultFormatter": "esbenp.prettier-vscode" "editor.defaultFormatter": "biomejs.biome"
}, },
"[typescript]": { "[typescript]": {
"editor.defaultFormatter": "esbenp.prettier-vscode" "editor.defaultFormatter": "biomejs.biome"
}, },
"[typescriptreact]": { "[typescriptreact]": {
"editor.defaultFormatter": "esbenp.prettier-vscode" "editor.defaultFormatter": "biomejs.biome"
},
"[html]": {
"editor.defaultFormatter": "esbenp.prettier-vscode"
},
"[css]": {
"editor.defaultFormatter": "esbenp.prettier-vscode"
},
"[json]": {
"editor.defaultFormatter": "esbenp.prettier-vscode"
},
"[jsonc]": {
"editor.defaultFormatter": "esbenp.prettier-vscode"
}, },
// Extensions - Biome
// - see: biome.json
// Exteions - cSpell // Exteions - cSpell
// - see: .cspell.json // - see: .cspell.json
// Extensions - ESLint
"eslint.enable": false,
// Extensions - HTML // Extensions - HTML
"html.format.wrapLineLength": 0, "html.format.wrapLineLength": 0,
// Extentions - Prettier
// - see: .prettierrc.json
// Extentions - Typescript // Extentions - Typescript
"javascript.updateImportsOnFileMove.enabled": "always", "javascript.updateImportsOnFileMove.enabled": "always",
"typescript.updateImportsOnFileMove.enabled": "always" "typescript.updateImportsOnFileMove.enabled": "always",
} }

43
biome.json Normal file
View File

@@ -0,0 +1,43 @@
{
"$schema": "https://biomejs.dev/schemas/2.2.4/schema.json",
"vcs": {
"enabled": true,
"clientKind": "git",
"useIgnoreFile": true
},
"files": {
"ignoreUnknown": false,
"includes": ["src/**"]
},
"formatter": {
"enabled": true,
"formatWithErrors": false,
"indentStyle": "space",
"lineEnding": "lf",
"indentWidth": 2,
"lineWidth": 120,
"attributePosition": "auto"
},
"linter": {
"enabled": true,
"domains": {
"react": "recommended"
},
"rules": {
"recommended": true
}
},
"javascript": {
"formatter": {
"quoteStyle": "single"
}
},
"assist": {
"enabled": true,
"actions": {
"source": {
"organizeImports": "on"
}
}
}
}

2874
package-lock.json generated

File diff suppressed because it is too large Load Diff

View File

@@ -10,45 +10,46 @@
"prebuild:prod": "npm run gen", "prebuild:prod": "npm run gen",
"build": "cross-env NODE_ENV=development rspack build", "build": "cross-env NODE_ENV=development rspack build",
"build:prod": "cross-env NODE_ENV=production rspack build", "build:prod": "cross-env NODE_ENV=production rspack build",
"lint": "eslint src --ext .js,.jsx,.ts,.tsx", "cspell": "cspell .",
"lint": "biome lint .",
"format": "biome check --write .",
"upload": "env-cmd --silent kintone-plugin-uploader dist/plugin.zip --watch --waiting-dialog-ms 3000" "upload": "env-cmd --silent kintone-plugin-uploader dist/plugin.zip --watch --waiting-dialog-ms 3000"
}, },
"dependencies": { "dependencies": {
"@kintone/rest-api-client": "^5.7.4", "@kintone/rest-api-client": "^5.7.5",
"angular-expressions": "^1.5.0", "angular-expressions": "^1.5.1",
"clsx": "^2.1.1", "clsx": "^2.1.1",
"dayjs": "^1.11.13", "dayjs": "^1.11.18",
"docxtemplater": "^3.65.1", "docxtemplater": "^3.66.4",
"file-saver": "^2.0.5", "file-saver": "^2.0.5",
"i18next": "^25.3.0", "i18next": "^25.5.2",
"moize": "^6.1.6", "moize": "^6.1.6",
"pizzip": "^3.2.0", "pizzip": "^3.2.0",
"react": "^19.1.0", "react": "^19.1.1",
"react-dom": "^19.1.0", "react-dom": "^19.1.1",
"react-error-boundary": "^6.0.0", "react-error-boundary": "^6.0.0",
"react-i18next": "^15.6.0", "react-i18next": "^16.0.0",
"tiny-invariant": "^1.3.3" "tiny-invariant": "^1.3.3"
}, },
"devDependencies": { "devDependencies": {
"@cybozu/eslint-config": "^24.0.0", "@biomejs/biome": "^2.2.4",
"@kintone/dts-gen": "^8.1.2", "@kintone/dts-gen": "^8.1.3",
"@kintone/plugin-uploader": "^9.1.5", "@kintone/plugin-uploader": "^9.1.5",
"@kintone/webpack-plugin-kintone-plugin": "^8.0.11", "@kintone/webpack-plugin-kintone-plugin": "^8.0.11",
"@rspack/cli": "^1.4.3", "@rspack/cli": "^1.5.8",
"@rspack/core": "^1.4.3", "@rspack/core": "^1.5.8",
"@shin-chan/kypes": "^0.0.7", "@shin-chan/kypes": "^0.0.7",
"@types/file-saver": "^2.0.7", "@types/file-saver": "^2.0.7",
"@types/node": "^24.0.10", "@types/node": "^24.6.0",
"@types/react": "^19.1.8", "@types/react": "^19.1.16",
"@types/react-dom": "^19.1.6", "@types/react-dom": "^19.1.9",
"cross-env": "^7.0.3", "cross-env": "^10.1.0",
"env-cmd": "^10.1.0", "cspell": "^9.2.1",
"eslint": "^9.30.1", "env-cmd": "^11.0.0",
"eslint-plugin-react": "^7.37.5", "globals": "^16.4.0",
"globals": "^16.3.0",
"npm-run-all": "^4.1.5", "npm-run-all": "^4.1.5",
"prettier": "^3.6.2", "prettier": "^3.6.2",
"ts-node": "^10.9.2", "ts-node": "^10.9.2",
"typescript": "^5.8.3" "typescript": "^5.9.2"
} }
} }

View File

@@ -1,5 +1,4 @@
import React from 'react'; import React from 'react';
import ReactDOM from 'react-dom'; import ReactDOM from 'react-dom';
import invariant from 'tiny-invariant'; import invariant from 'tiny-invariant';
@@ -21,8 +20,7 @@ const DynamicPortal: React.FC<DynamicPortalProps> = (props) => {
el.parentNode.removeChild(el); el.parentNode.removeChild(el);
} }
}; };
// eslint-disable-next-line react-hooks/exhaustive-deps }, [el]);
}, []);
return ReactDOM.createPortal(children, el); return ReactDOM.createPortal(children, el);
}; };
export default DynamicPortal; export default DynamicPortal;

View File

@@ -1,5 +1,5 @@
// biome-ignore lint/style/useImportType: React is required in scope for the old JSX transform.
import React from 'react'; import React from 'react';
import KintonePluginAlert from './ui/KintonePluginAlert'; import KintonePluginAlert from './ui/KintonePluginAlert';
interface Props { interface Props {

View File

@@ -1,5 +1,5 @@
// biome-ignore lint/style/useImportType: React is required in scope for the old JSX transform.
import React from 'react'; import React from 'react';
import DynamicPortal from './DynamicPortal'; import DynamicPortal from './DynamicPortal';
import styles from './Loading.module.css'; import styles from './Loading.module.css';

View File

@@ -1,4 +1,4 @@
import { LanguageDetectorModule } from 'i18next'; import type { LanguageDetectorModule } from 'i18next';
const KintoneLanguageDetector: LanguageDetectorModule = { const KintoneLanguageDetector: LanguageDetectorModule = {
type: 'languageDetector', type: 'languageDetector',

View File

@@ -1,4 +1,4 @@
import { KintoneFormFieldProperty } from '@kintone/rest-api-client'; import type { KintoneFormFieldProperty } from '@kintone/rest-api-client';
export type KintoneFormFieldProperties = { export type KintoneFormFieldProperties = {
[fieldCode: string]: KintoneFormFieldProperty.OneOf; [fieldCode: string]: KintoneFormFieldProperty.OneOf;

File diff suppressed because one or more lines are too long

View File

@@ -1,6 +1,6 @@
import React from 'react';
import clsx from 'clsx'; import clsx from 'clsx';
// biome-ignore lint/style/useImportType: React is required in scope for the old JSX transform.
import React from 'react';
export type KintonePluginAlertProps = React.PropsWithChildren<{ export type KintonePluginAlertProps = React.PropsWithChildren<{
className?: string; className?: string;

View File

@@ -1,6 +1,6 @@
import React from 'react';
import clsx from 'clsx'; import clsx from 'clsx';
// biome-ignore lint/style/useImportType: React is required in scope for the old JSX transform.
import React from 'react';
export type KintonePluginButtonProps = React.PropsWithChildren<{ export type KintonePluginButtonProps = React.PropsWithChildren<{
className?: string; className?: string;

View File

@@ -1,6 +1,6 @@
import React from 'react';
import clsx from 'clsx'; import clsx from 'clsx';
// biome-ignore lint/style/useImportType: React is required in scope for the old JSX transform.
import React from 'react';
export type KintonePluginDescProps = React.PropsWithChildren<{ export type KintonePluginDescProps = React.PropsWithChildren<{
className?: string; className?: string;

View File

@@ -1,6 +1,6 @@
import React from 'react';
import clsx from 'clsx'; import clsx from 'clsx';
// biome-ignore lint/style/useImportType: React is required in scope for the old JSX transform.
import React from 'react';
export type KintonePluginLabelProps = React.PropsWithChildren<{ export type KintonePluginLabelProps = React.PropsWithChildren<{
className?: string; className?: string;

View File

@@ -1,6 +1,6 @@
import React from 'react';
import clsx from 'clsx'; import clsx from 'clsx';
// biome-ignore lint/style/useImportType: React is required in scope for the old JSX transform.
import React from 'react';
export type KintonePluginRequire = React.PropsWithChildren<{ export type KintonePluginRequire = React.PropsWithChildren<{
className?: string; className?: string;

View File

@@ -1,6 +1,6 @@
import React from 'react';
import clsx from 'clsx'; import clsx from 'clsx';
// biome-ignore lint/style/useImportType: React is required in scope for the old JSX transform.
import React from 'react';
export type KintonePluginRowProps = React.PropsWithChildren<{ export type KintonePluginRowProps = React.PropsWithChildren<{
className?: string; className?: string;

View File

@@ -1,6 +1,5 @@
import React from 'react';
import clsx from 'clsx'; import clsx from 'clsx';
import React from 'react';
export type KintonePluginSelectOptionData = { export type KintonePluginSelectOptionData = {
value: string; value: string;

View File

@@ -1,6 +1,5 @@
import React from 'react';
import clsx from 'clsx'; import clsx from 'clsx';
import type React from 'react';
export type KintonePluginTitleProps = React.PropsWithChildren<{ export type KintonePluginTitleProps = React.PropsWithChildren<{
className?: string; className?: string;

View File

@@ -1,5 +1,4 @@
import React from 'react'; import React from 'react';
import { ErrorBoundary } from 'react-error-boundary'; import { ErrorBoundary } from 'react-error-boundary';
import ErrorFallback from '../common/ErrorFallback'; import ErrorFallback from '../common/ErrorFallback';
import Loading from '../common/Loading'; import Loading from '../common/Loading';

View File

@@ -1,18 +1,17 @@
import React from 'react';
import { KintoneRestAPIClient } from '@kintone/rest-api-client'; import { KintoneRestAPIClient } from '@kintone/rest-api-client';
import moize from 'moize'; import moize from 'moize';
import React from 'react';
import { useTranslation } from 'react-i18next'; import { useTranslation } from 'react-i18next';
import invariant from 'tiny-invariant'; import invariant from 'tiny-invariant';
import { naturalCompare } from '../common/stringUtils'; import { naturalCompare } from '../common/stringUtils';
import { KintoneFormFieldProperties } from '../common/types'; import type { KintoneFormFieldProperties } from '../common/types';
import KintonePluginAlert from '../common/ui/KintonePluginAlert'; import KintonePluginAlert from '../common/ui/KintonePluginAlert';
import KintonePluginButton from '../common/ui/KintonePluginButton'; import KintonePluginButton from '../common/ui/KintonePluginButton';
import KintonePluginDesc from '../common/ui/KintonePluginDesc'; import KintonePluginDesc from '../common/ui/KintonePluginDesc';
import KintonePluginLabel from '../common/ui/KintonePluginLabel'; import KintonePluginLabel from '../common/ui/KintonePluginLabel';
import KintonePluginRequire from '../common/ui/KintonePluginRequire'; import KintonePluginRequire from '../common/ui/KintonePluginRequire';
import KintonePluginRow from '../common/ui/KintonePluginRow'; import KintonePluginRow from '../common/ui/KintonePluginRow';
import KintonePluginSelect, { KintonePluginSelectOptionData } from '../common/ui/KintonePluginSelect'; import KintonePluginSelect, { type KintonePluginSelectOptionData } from '../common/ui/KintonePluginSelect';
import KintonePluginTitle from '../common/ui/KintonePluginTitle'; import KintonePluginTitle from '../common/ui/KintonePluginTitle';
import styles from './Settings.module.css'; import styles from './Settings.module.css';

View File

@@ -1,5 +1,4 @@
import React from 'react'; import React from 'react';
import ReactDOM from 'react-dom/client'; import ReactDOM from 'react-dom/client';
import invariant from 'tiny-invariant'; import invariant from 'tiny-invariant';
import ConfigApp from './ConfigApp'; import ConfigApp from './ConfigApp';

View File

@@ -1,5 +1,4 @@
import React from 'react'; import React from 'react';
import { ErrorBoundary } from 'react-error-boundary'; import { ErrorBoundary } from 'react-error-boundary';
import ErrorFallback from '../common/ErrorFallback'; import ErrorFallback from '../common/ErrorFallback';
import Loading from '../common/Loading'; import Loading from '../common/Loading';

View File

@@ -1,17 +1,16 @@
import React from 'react'; import { type KintoneFormFieldProperty, KintoneRestAPIClient } from '@kintone/rest-api-client';
import type { KintoneRecord } from '@shin-chan/kypes/types/page';
import { KintoneFormFieldProperty, KintoneRestAPIClient } from '@kintone/rest-api-client';
import { KintoneRecord } from '@shin-chan/kypes/types/page';
import dayjs from 'dayjs'; import dayjs from 'dayjs';
import Docxtemplater from 'docxtemplater'; import Docxtemplater from 'docxtemplater';
import expressionParser from 'docxtemplater/expressions'; import expressionParser from 'docxtemplater/expressions';
import { saveAs } from 'file-saver'; import { saveAs } from 'file-saver';
import moize from 'moize'; import moize from 'moize';
import PizZip from 'pizzip'; import PizZip from 'pizzip';
import React from 'react';
import { useTranslation } from 'react-i18next'; import { useTranslation } from 'react-i18next';
import invariant from 'tiny-invariant'; import invariant from 'tiny-invariant';
import { DOCX_CONTENT_TYPE } from '../common/constants'; import { DOCX_CONTENT_TYPE } from '../common/constants';
import { KintoneFormFieldProperties } from '../common/types'; import type { KintoneFormFieldProperties } from '../common/types';
import KintonePluginAlert from '../common/ui/KintonePluginAlert'; import KintonePluginAlert from '../common/ui/KintonePluginAlert';
import KintonePluginButton from '../common/ui/KintonePluginButton'; import KintonePluginButton from '../common/ui/KintonePluginButton';
@@ -31,7 +30,7 @@ const cachedFormFieldsProperties = moize.promise(async (appId: number): Promise<
}); });
const formatNumberValue = (value: string, digit: boolean, scale?: number): string => { const formatNumberValue = (value: string, digit: boolean, scale?: number): string => {
if (value !== '' && !isNaN(Number(value))) { if (value !== '' && !Number.isNaN(Number(value))) {
const numberValue = Number(value); const numberValue = Number(value);
const options: Intl.NumberFormatOptions = { const options: Intl.NumberFormatOptions = {
useGrouping: digit, useGrouping: digit,
@@ -90,18 +89,18 @@ const formatCalculatedRecordValue = (
} else if (format === 'DATETIME') { } else if (format === 'DATETIME') {
// "2025-05-30T00:00:00Z" -> "2025-05-30 9:00" (browser local timezone) // "2025-05-30T00:00:00Z" -> "2025-05-30 9:00" (browser local timezone)
const date = new Date(value); const date = new Date(value);
invariant(!isNaN(date.getTime()), `Expected value to be a valid date string, but got ${value}`); invariant(!Number.isNaN(date.getTime()), `Expected value to be a valid date string, but got ${value}`);
formattedValue = dayjs(date).format('YYYY-MM-DD h:mm'); formattedValue = dayjs(date).format('YYYY-MM-DD h:mm');
} else if (format === 'DATE') { } else if (format === 'DATE') {
// "2025-05-30T00:00:00Z" -> "2025-05-30" (browser local timezone) // "2025-05-30T00:00:00Z" -> "2025-05-30" (browser local timezone)
const date = new Date(value); const date = new Date(value);
invariant(!isNaN(date.getTime()), `Expected value to be a valid date string, but got ${value}`); invariant(!Number.isNaN(date.getTime()), `Expected value to be a valid date string, but got ${value}`);
formattedValue = dayjs(date).format('YYYY-MM-DD'); formattedValue = dayjs(date).format('YYYY-MM-DD');
} else if (format === 'TIME') { } else if (format === 'TIME') {
// "00:30" -> "0:30" // "00:30" -> "0:30"
const [hours, minutes] = value.split(':').map((v) => Number(v)); const [hours, minutes] = value.split(':').map((v) => Number(v));
invariant( invariant(
!isNaN(hours) && !isNaN(minutes), !Number.isNaN(hours) && !Number.isNaN(minutes),
`Expected hours and minutes to be numbers, but got hours: ${hours}, minutes: ${minutes}`, `Expected hours and minutes to be numbers, but got hours: ${hours}, minutes: ${minutes}`,
); );
formattedValue = `${hours}:${String(minutes).padStart(2, '0')}`; formattedValue = `${hours}:${String(minutes).padStart(2, '0')}`;
@@ -109,7 +108,7 @@ const formatCalculatedRecordValue = (
// "49:30" -> en:"49 hours 30 minutes", ja: "49時間30分" // "49:30" -> en:"49 hours 30 minutes", ja: "49時間30分"
const [hours, minutes] = value.split(':').map((v) => Number(v)); const [hours, minutes] = value.split(':').map((v) => Number(v));
invariant( invariant(
!isNaN(hours) && !isNaN(minutes), !Number.isNaN(hours) && !Number.isNaN(minutes),
`Expected hours and minutes to be numbers, but got hours: ${hours}, minutes: ${minutes}`, `Expected hours and minutes to be numbers, but got hours: ${hours}, minutes: ${minutes}`,
); );
formattedValue = language === 'ja' ? `${hours}時間${minutes}` : `${hours} hours ${minutes} minutes`; formattedValue = language === 'ja' ? `${hours}時間${minutes}` : `${hours} hours ${minutes} minutes`;
@@ -117,7 +116,7 @@ const formatCalculatedRecordValue = (
// "49:30" -> en: "2 days 1 hour 30 minutes", ja: "2日1時間30分 // "49:30" -> en: "2 days 1 hour 30 minutes", ja: "2日1時間30分
const [hours, minutes] = value.split(':').map((v) => Number(v)); const [hours, minutes] = value.split(':').map((v) => Number(v));
invariant( invariant(
!isNaN(hours) && !isNaN(minutes), !Number.isNaN(hours) && !Number.isNaN(minutes),
`Expected hours and minutes to be numbers, but got hours: ${hours}, minutes: ${minutes}`, `Expected hours and minutes to be numbers, but got hours: ${hours}, minutes: ${minutes}`,
); );
const days = Math.floor(Number(hours) / 24); const days = Math.floor(Number(hours) / 24);
@@ -140,6 +139,7 @@ const record2data = (
): TemplateData => { ): TemplateData => {
const data: TemplateData = {}; const data: TemplateData = {};
for (const key in record) { for (const key in record) {
// biome-ignore lint/suspicious/noPrototypeBuiltins: avoid prototype pollution
if (Object.prototype.hasOwnProperty.call(record, key) && Object.prototype.hasOwnProperty.call(properties, key)) { if (Object.prototype.hasOwnProperty.call(record, key) && Object.prototype.hasOwnProperty.call(properties, key)) {
const item = record[key]; const item = record[key];
const property = properties[key]; const property = properties[key];

View File

@@ -1,5 +1,4 @@
import React from 'react'; import React from 'react';
import ReactDOM from 'react-dom/client'; import ReactDOM from 'react-dom/client';
import invariant from 'tiny-invariant'; import invariant from 'tiny-invariant';
import DesktopApp from './DesktopApp'; import DesktopApp from './DesktopApp';

View File

@@ -19,7 +19,8 @@
"noUnusedLocals": true, "noUnusedLocals": true,
"noUnusedParameters": true "noUnusedParameters": true
}, },
"include": ["src/**/*", "./node_modules/@kintone/dts-gen/kintone.d.ts"], "files": ["./node_modules/@kintone/dts-gen/kintone.d.ts"],
"include": ["src/**/*"],
"ts-node": { "ts-node": {
"compilerOptions": { "compilerOptions": {
"module": "CommonJS" "module": "CommonJS"