Fetching a locked folder before its password is sent returns 200 with
only its listing fields, without metadata, sub_folders and path, so
FoldersApi.retrieve failed with a pydantic ValidationError. The DOI
route fetches the folder before it can see the lock, so a
password-protected DOI folder could not be opened even with its
password.
- Add FolderLockedException, a subclass of UnauthorizedException, and
raise it from retrieve on that short record and from the lock checks.
- On a DOI folder, send the password and fetch it again when the first
fetch finds it locked.
flake8 reported 49 findings and pyright 10, and two of them were real
bugs rather than matters of style. The rest were unused imports and
four functions over the complexity limit.
- Unlock a DOI folder with the id the DOI response carries, rather
than an attribute the model does not have, which raised
`AttributeError` on every locked DOI folder.
- Size the `ls` Size column from the sub-folder on the row rather than
from its parent, which pushed the later columns out of line.
- Share the path resolution and the destination checks between `cp`
and `mv`, and split the recursive download and the `ls` row
printing, bringing all four functions under the complexity limit.
- Accept a client built without a connection, which `config` and
`version` rely on, and report the reason if one is then asked for.
- Declare the config protocol's constructor for the type checker
alone, so the protocol keeps its guard against being instantiated.
- Remove 41 unused imports, and let flake8 accept black's spacing.
- Point pyright at the project's own environment, without which it
resolved no dependency and reported 124 findings that were not real.
- Cover the two fixes and the shared `cp`/`mv` paths with new tests.
orrisroot